-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump scipy from 1.14.0 to 1.14.1 #84
Conversation
Bumps [scipy](https://github.com/scipy/scipy) from 1.14.0 to 1.14.1. - [Release notes](https://github.com/scipy/scipy/releases) - [Commits](scipy/scipy@v1.14.0...v1.14.1) --- updated-dependencies: - dependency-name: scipy dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
WalkthroughThe changes include updates to several Jupyter notebooks, enhancing code readability and consistency through formatting adjustments. Key modifications involve the addition of future import statements for type annotations, standardisation of string formatting, updates to model IDs and output messages related to parallel computing, and enhancements to function signatures for clearer documentation. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Notebook
participant MPI Engine
User->>Notebook: Execute Code
Notebook->>MPI Engine: Start Parallel Processing
MPI Engine-->>Notebook: Return Output
Notebook->>User: Display Results
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #84 +/- ##
=======================================
Coverage 39.20% 39.20%
=======================================
Files 3 3
Lines 477 477
=======================================
Hits 187 187
Misses 290 290 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
pyproject.toml
is excluded by!**/*.toml
Files selected for processing (4)
- examples/00_Introduction.ipynb (1 hunks)
- examples/03_mpi/mimimise_convert_backend.ipynb (1 hunks)
- examples/03_mpi/mimimise_convert_backend2.ipynb (6 hunks)
- examples/03_mpi/mpi_test.ipynb (6 hunks)
Files skipped from review due to trivial changes (3)
- examples/00_Introduction.ipynb
- examples/03_mpi/mimimise_convert_backend.ipynb
- examples/03_mpi/mimimise_convert_backend2.ipynb
Additional comments not posted (8)
examples/03_mpi/mpi_test.ipynb (8)
19-21
: LGTM!The model ID update is appropriate and likely reflects an update in the widget state or configuration.
The code changes are approved.
34-37
: LGTM!The output messages have been updated appropriately to reflect new engine identifiers and exit codes.
The code changes are approved.
42-42
: LGTM!The addition of the future import statement for type annotations enhances code readability and consistency.
The code changes are approved.
78-80
: LGTM!The model ID update is appropriate and likely reflects an update in the widget state or configuration.
The code changes are approved.
93-111
: Verify the handling of the new error state.The exit code for one of the engines has been modified from
0
to255
, indicating a failure or error state during execution. Ensure that the error state is handled appropriately in the notebook's execution flow.Please verify that the error state is handled correctly in the notebook's execution flow.
118-118
: LGTM!The addition of the return type annotation for
mpi_example
enhances the clarity of the function's expected output, improving code readability and maintainability.The code changes are approved.
125-125
: LGTM!The code correctly sets up an MPI cluster with 4 engines and runs the
mpi_example
function on all engines in parallel. The changes are consistent with the expected behaviour of parallel execution.The code changes are approved.
125-125
: LGTM!The comment indicating that the cluster processes have been shut down provides useful information about the state of the cluster processes, improving code readability and maintainability.
The code changes are approved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- .pre-commit-config.yaml (1 hunks)
- examples/03_mpi/mimimise_convert_backend.ipynb (1 hunks)
- examples/03_mpi/mimimise_convert_backend2.ipynb (10 hunks)
Files skipped from review due to trivial changes (1)
- examples/03_mpi/mimimise_convert_backend2.ipynb
Files skipped from review as they are similar to previous changes (1)
- examples/03_mpi/mimimise_convert_backend.ipynb
Additional comments not posted (1)
.pre-commit-config.yaml (1)
50-54
: LGTM!The addition of
nbstripout
is a good practice for managing Jupyter notebook files by stripping out output and empty cells. This helps maintain cleaner version control for Jupyter notebooks.The code changes are approved.
Bumps scipy from 1.14.0 to 1.14.1.
Release notes
Sourced from scipy's releases.
Commits
92d2a85
REL: 1.14.1 rel commit [wheel build]85623a1
Merge pull request #21362 from tylerjereddy/treddy_1.14.1_backportsd924005
MAINT: PR 21362 revisions [wheel build]b901a4e
MAINT, CI: PR 21362 revisions [wheel build]2a7ec60
MAINT, BLD: PR 21362 revisions [wheel build]f4f084d
MAINT, CI: PR 21362 revisions [wheel build]b712fc6
DOC: update 1.14.1 relnotes [wheel build]cdd5aca
MAINT: special: Accommodate changed integer handling in NumPy 2.0. (#21401)0f91838
BLD: cp313 wheels onmanylinux_aarch64
(#21409)6dd0b00
MAINT, CI: wheel build changes [wheel build]Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)