Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump scipy from 1.14.0 to 1.14.1 #84

Merged
merged 4 commits into from
Aug 27, 2024
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 26, 2024

Bumps scipy from 1.14.0 to 1.14.1.

Release notes

Sourced from scipy's releases.

SciPy 1.14.1 Release Notes

SciPy 1.14.1 adds support for Python 3.13, including binary wheels on PyPI. Apart from that, it is a bug-fix release with no new features compared to 1.14.0.

Authors

  • Name (commits)
  • h-vetinari (1)
  • Evgeni Burovski (1)
  • CJ Carey (2)
  • Lucas Colley (3)
  • Ralf Gommers (3)
  • Melissa Weber Mendonça (1)
  • Andrew Nelson (3)
  • Nick ODell (1)
  • Tyler Reddy (36)
  • Daniel Schmitz (1)
  • Dan Schult (4)
  • Albert Steppi (2)
  • Ewout ter Hoeven (1)
  • Tibor Völcker (2) +
  • Adam Turner (1) +
  • Warren Weckesser (2)
  • ਗਗਨਦੀਪ ਸਿੰਘ (Gagandeep Singh) (1)

A total of 17 people contributed to this release. People with a "+" by their names contributed a patch for the first time. This list of names is automatically generated, and may not be fully complete.

Commits
  • 92d2a85 REL: 1.14.1 rel commit [wheel build]
  • 85623a1 Merge pull request #21362 from tylerjereddy/treddy_1.14.1_backports
  • d924005 MAINT: PR 21362 revisions [wheel build]
  • b901a4e MAINT, CI: PR 21362 revisions [wheel build]
  • 2a7ec60 MAINT, BLD: PR 21362 revisions [wheel build]
  • f4f084d MAINT, CI: PR 21362 revisions [wheel build]
  • b712fc6 DOC: update 1.14.1 relnotes [wheel build]
  • cdd5aca MAINT: special: Accommodate changed integer handling in NumPy 2.0. (#21401)
  • 0f91838 BLD: cp313 wheels on manylinux_aarch64 (#21409)
  • 6dd0b00 MAINT, CI: wheel build changes [wheel build]
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [scipy](https://github.com/scipy/scipy) from 1.14.0 to 1.14.1.
- [Release notes](https://github.com/scipy/scipy/releases)
- [Commits](scipy/scipy@v1.14.0...v1.14.1)

---
updated-dependencies:
- dependency-name: scipy
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Aug 26, 2024
Copy link

coderabbitai bot commented Aug 26, 2024

Walkthrough

The changes include updates to several Jupyter notebooks, enhancing code readability and consistency through formatting adjustments. Key modifications involve the addition of future import statements for type annotations, standardisation of string formatting, updates to model IDs and output messages related to parallel computing, and enhancements to function signatures for clearer documentation.

Changes

Files Change Summary
examples/00_Introduction.ipynb Added a code cell with a placeholder comment and updated notebook format to version 4.2.
examples/03_mpi/mimimise_convert_backend.ipynb Introduced from __future__ import annotations for postponed evaluation of type annotations.
examples/03_mpi/mimimise_convert_backend2.ipynb Added future annotations, standardised string formatting, and updated ANSI escape codes.
examples/03_mpi/mpi_test.ipynb Updated model IDs, modified output messages, changed exit codes, and added return type annotation to mpi_example.
.pre-commit-config.yaml Added entry for nbstripout to manage Jupyter notebook output and empty cells.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Notebook
    participant MPI Engine

    User->>Notebook: Execute Code
    Notebook->>MPI Engine: Start Parallel Processing
    MPI Engine-->>Notebook: Return Output
    Notebook->>User: Display Results
Loading

🐰 In the meadow, changes bloom,
A future bright, dispelling gloom.
Code flows smooth, with annotations clear,
In the world of bytes, we hop with cheer!
Let's celebrate, with joy we sing,
For every change, new wonders bring! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.20%. Comparing base (aa0f6e8) to head (b61dca1).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #84   +/-   ##
=======================================
  Coverage   39.20%   39.20%           
=======================================
  Files           3        3           
  Lines         477      477           
=======================================
  Hits          187      187           
  Misses        290      290           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between aa0f6e8 and f777f22.

Files ignored due to path filters (1)
  • pyproject.toml is excluded by !**/*.toml
Files selected for processing (4)
  • examples/00_Introduction.ipynb (1 hunks)
  • examples/03_mpi/mimimise_convert_backend.ipynb (1 hunks)
  • examples/03_mpi/mimimise_convert_backend2.ipynb (6 hunks)
  • examples/03_mpi/mpi_test.ipynb (6 hunks)
Files skipped from review due to trivial changes (3)
  • examples/00_Introduction.ipynb
  • examples/03_mpi/mimimise_convert_backend.ipynb
  • examples/03_mpi/mimimise_convert_backend2.ipynb
Additional comments not posted (8)
examples/03_mpi/mpi_test.ipynb (8)

19-21: LGTM!

The model ID update is appropriate and likely reflects an update in the widget state or configuration.

The code changes are approved.


34-37: LGTM!

The output messages have been updated appropriately to reflect new engine identifiers and exit codes.

The code changes are approved.


42-42: LGTM!

The addition of the future import statement for type annotations enhances code readability and consistency.

The code changes are approved.


78-80: LGTM!

The model ID update is appropriate and likely reflects an update in the widget state or configuration.

The code changes are approved.


93-111: Verify the handling of the new error state.

The exit code for one of the engines has been modified from 0 to 255, indicating a failure or error state during execution. Ensure that the error state is handled appropriately in the notebook's execution flow.

Please verify that the error state is handled correctly in the notebook's execution flow.


118-118: LGTM!

The addition of the return type annotation for mpi_example enhances the clarity of the function's expected output, improving code readability and maintainability.

The code changes are approved.


125-125: LGTM!

The code correctly sets up an MPI cluster with 4 engines and runs the mpi_example function on all engines in parallel. The changes are consistent with the expected behaviour of parallel execution.

The code changes are approved.


125-125: LGTM!

The comment indicating that the cluster processes have been shut down provides useful information about the state of the cluster processes, improving code readability and maintainability.

The code changes are approved.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f777f22 and b61dca1.

Files selected for processing (3)
  • .pre-commit-config.yaml (1 hunks)
  • examples/03_mpi/mimimise_convert_backend.ipynb (1 hunks)
  • examples/03_mpi/mimimise_convert_backend2.ipynb (10 hunks)
Files skipped from review due to trivial changes (1)
  • examples/03_mpi/mimimise_convert_backend2.ipynb
Files skipped from review as they are similar to previous changes (1)
  • examples/03_mpi/mimimise_convert_backend.ipynb
Additional comments not posted (1)
.pre-commit-config.yaml (1)

50-54: LGTM!

The addition of nbstripout is a good practice for managing Jupyter notebook files by stripping out output and empty cells. This helps maintain cleaner version control for Jupyter notebooks.

The code changes are approved.

@ab5424 ab5424 merged commit fcdd01a into main Aug 27, 2024
10 checks passed
@ab5424 ab5424 deleted the dependabot/pip/scipy-1.14.1 branch August 27, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant